Skip to content

Conversation

@khorne3
Copy link
Collaborator

@khorne3 khorne3 commented Oct 3, 2025

This PR splits the existing taint analysis doc into two docs (one overview, one for advanced techniques). There's no new content; there are only copyedits and section reorgs plus link and anchor fixes as necessary.

@netlify
Copy link

netlify bot commented Oct 3, 2025

Don't forget to add /docs at the end of the deploy preview site URL!

Name Link
🔨 Latest commit a2a385d
🔍 Latest deploy log https://app.netlify.com/projects/semgrep-docs-prod/deploys/68fa3738fd7f280008b7e67a
😎 Deploy Preview https://deploy-preview-2346--semgrep-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@khorne3 khorne3 marked this pull request as ready for review October 16, 2025 15:06
@khorne3 khorne3 requested a review from abhijna October 16, 2025 15:06
@abhijna
Copy link
Collaborator

abhijna commented Oct 20, 2025

Looks great! I have one small suggestion:

It’s a bit difficult to find the taint analysis docs. When you click Rule writing from the left navigation, this is what appears:
Screenshot 2025-10-20 at 9 21 47 AM

My first instinct would be to expand the navigation automatically when someone enters a subsection. Since we’re not planning to do that, it might be helpful to ensure that the taint analysis docs are cross-linked from more prominent pages.

@khorne3
Copy link
Collaborator Author

khorne3 commented Oct 23, 2025

@abhijna Just FYI that it isn't all or nothing when it comes to expanding the individual sections; if you take a look at sidebars.js, I changed it so that the taint analysis docs are shown if the Advanced rule-writing techniques section is open (otherwise, I think it's fine to remain hidden)

@khorne3 khorne3 merged commit 4818456 into main Oct 23, 2025
10 checks passed
@khorne3 khorne3 deleted the katiehorne/tec-271-create-intro-and-advanced-articles-for-taint-mode-rules branch October 23, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants